Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RenderCallExtractor to be compatible with Ruby 3.3 #49416

Merged

Conversation

casperisfine
Copy link
Contributor

Fix: #49128
Ref: ruby/ruby@45cd011d73

We need to unwrap some nodes.

@rails-bot rails-bot bot added the actionview label Sep 28, 2023
@rafaelfranca rafaelfranca merged commit af95a7d into rails:main Sep 28, 2023
4 checks passed
@rafaelfranca rafaelfranca deleted the fix-render-call-extractor-on-ruby-3.3 branch September 28, 2023 15:57
rafaelfranca added a commit that referenced this pull request Sep 28, 2023
…uby-3.3

Fix RenderCallExtractor to be compatible with Ruby 3.3
@skipkayhil
Copy link
Member

@rafaelfranca should we backport this to 7-0-stable as well?

@casperisfine
Copy link
Contributor Author

@skipkayhil yes. My bad should have thought of it.

rafaelfranca added a commit that referenced this pull request Oct 3, 2023
…uby-3.3

Fix RenderCallExtractor to be compatible with Ruby 3.3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RipperTrackerTest#test_finds_dependencies_with_extra_spaces fails
4 participants