Turn skips into errors on Rails CI #49455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
casperisfine
force-pushed
the
no-skip-on-ci
branch
2 times, most recently
from
b933767
to
a66d266
Compare
|
There will be quite a bit of cleanup to do before this can be merged. |
|
@casperisfine If you want we can add a soft-fail job in CI then fix the failures incrementally? |
casperisfine
force-pushed
the
no-skip-on-ci
branch
from
a66d266
to
d7977aa
Compare
We had a few cases of tests being skipped accidentally on CI hence not bein ran for a long time. Skipping make sense when running the test suite locally, e.g. you may not have Redis or some other dependency running. But on CI, a test not being ran should be considered an error.
casperisfine
force-pushed
the
no-skip-on-ci
branch
from
d7977aa
to
9497f47
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had a few cases of tests being skipped accidentally on CI hence not being ran for a long time (e.g. #49414).
Skipping make sense when running the test suite locally, e.g. you may not have Redis or some other dependency running.
But on CI, a test not being ran should be considered an error.