Improve instrumentation tests

[p8]

Don't build AS::Notifications::Event manually, similar to 95b6fbd.
Related to #49442 (comment)

Also assert that options get passed.

Checklist

Before submitting the PR make sure the following are checked:

• This Pull Request is related to one change. Changes that are unrelated should be opened in separate PRs.
• Commit message has a detailed description of what changed and why. If this PR fixes a related issue include it in the commit message. Ex: [Fix #issue-number]
• Tests are added or updated if you fix a bug or add a feature.
• CHANGELOG files are updated for the changed libraries if there is a behavior change or additional feature. Minor bug fixes and documentation changes should not be included.

[eugeneius]

What about:

Suggested change

	subscriber = proc do |_, _, _, _, event_payload|
	payload = event_payload
	end
	subscriber = proc do |event|
	payload = event.payload
	end

Or even:

Suggested change

	subscriber = proc do |_, _, _, _, event_payload|
	payload = event_payload
	end
	subscriber = proc { |event| payload = event.payload }

The four ignored block arguments are noisier visually than manually building the event, imo 🤷

[p8]

I agree and had that at first.
Then I saw similar test had this pattern instead.
I'll update those as well.

[p8]

Ah, sorry. I didn't notice the example of moving it to a single line, which is even better IMO.

[eugeneius]

No worries, it's a very minor difference 🙂

[p8]

😄