New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure `#signed_id` outputs `url_safe` strings #49507

Merged

dhh merged 1 commit into rails:main from terracatta:url_safe_signed_ids

Oct 6, 2023

Contributor

terracatta commented Oct 5, 2023 •

edited

Fixes #49505

When @dhh introduced signed_ids he likely always intended them to be url safe.

Since the intent of signed_ids is to be included in things like URL params, we should be passing url_safe: true option to MessageVerifier.

This PR does exactly that.


          Ensure #signed_id outputs url_safe strings

643ca47

rails-bot bot added the activerecord label

dhh merged commit fc5c8d0 into rails:main

4 checks passed

terracatta deleted the url_safe_signed_ids branch

October 6, 2023 14:04

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment