Don't log enqueuing details when the job wasn't enqueued

[dustinbrownman]

Motivation / Background

This Pull Request was created to fix a small bug introduced in #48066.

Detail

This changes the logged message when a job is started. Before, the logged message always attempted to include the enqueued_at info. Unfortunately, for jobs that are run with perform_now, they are not enqueued and instead executed immediately. This left enqueued_at as nil which in turn caused a NoMethodError to be raised when attempting to call utc on the nil value.

Checklist

Before submitting the PR make sure the following are checked:

• This Pull Request is related to one change. Changes that are unrelated should be opened in separate PRs.
• Commit message has a detailed description of what changed and why. If this PR fixes a related issue include it in the commit message. Ex: [Fix #issue-number]
• Tests are added or updated if you fix a bug or add a feature.
• CHANGELOG files are updated for the changed libraries if there is a behavior change or additional feature. Minor bug fixes and documentation changes should not be included.

[zzak]

Thanks for the PR!

Could you please squash your commits? 🙇

[dustinbrownman]

@zzak Thanks for taking a look! Apologies for not squashing before opening the PR. That's been done now 👍🏻

[zzak]

LGTM, @bensheldon wdyt?

[bensheldon]

I think the change looks good in the context of avoiding the error and is a definite improvement.

In terms of "is it the ideal error message for perform_now?" it also makes me think: the log message should also exclude the queue name. But that looks harder to do and that could be looked into separately.

👍

[dustinbrownman]

@bensheldon That's totally fair, and something I was considering when making this change. I agree that it would be a bigger change to do this correctly. With this change I'm inferring that the job wasn't enqueued with perform_later since enqueued_at isn't set, which happens during serialization. If we want to change the log message to be something like "Performing MyJob (Job ID: 123) immediately", I'd want to be more sure that was the case, perhaps with a flag that is set during perform_now or something.

I'd love to explore that more, but I think that doing so separately is probably the way to go.