Add doc to explain how to migrate to the new BroadcastLogger: #49518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zzak
reviewed
Oct 6, 2023
zzak
reviewed
Oct 6, 2023
zzak
reviewed
Oct 6, 2023
zzak
reviewed
Oct 6, 2023
zzak
reviewed
Oct 6, 2023
- This should make it easier for apps or libraries that were previously relying on the private API. Also took the opportunity to tweak the doc of the BroadcastLogger to mention what happens when calling a non-standard method. Fix rails#49494
Edouard-chin
force-pushed
the
ec-logger-doc
branch
from
84573a7
to
8be0c10
Compare
|
Thanks for the corrections ! |
eileencodes
pushed a commit
that referenced
this pull request
Oct 11, 2023
Add doc to explain how to migrate to the new BroadcastLogger:
|
Backported to 7-1-stable in 773e4a6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add doc to explain how to migrate to the new BroadcastLogger:
This should make it easier for apps or libraries that were previously relying on the private API. Also took the opportunity to tweak the doc of the BroadcastLogger to mention what happens when calling a non-standard method.
Fix Indicate in the changelog/release notes for 7.1, that
Rails.loggeris now aBroadcastLogger#49494cc/ @mensfeld Hopefully this should make it clearer!