Fix reverting rename_table for older migrations
#49526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you, @fatkodima! (╯°□°)╯︵ ┻━┻ Backported to |
jonathanhefner
added a commit
that referenced
this pull request
Oct 7, 2023
Fix reverting `rename_table` for older migrations (cherry picked from commit 04b3504)
jonathanhefner
added a commit
that referenced
this pull request
Oct 7, 2023
sue445
added a commit
to sue445/activerecord-simple_index_name
that referenced
this pull request
Oct 12, 2023
…n version less than 7.1" This reverts commit 538a211. This is fixed at rails/rails#49526
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #49523.
Previously, when reversing arguments (
args.reverse) if we had options (for example, it is set via compatibility migration for 7.0), it will incorrectly become the first argument.