[Tests only] Enable Minitest/AssertPredicate rule
#49628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rails-bot
bot
added
actioncable
actionmailbox
actionpack
actiontext
actionview
activemodel
labels
nvasilevski
commented
Oct 13, 2023
| @@ -726,7 +726,7 @@ class ActiveStorage::ManyAttachedTest < ActiveSupport::TestCase | |||
|
|
|||
| test "clearing change on reload" do | |||
| @user.highlights = [ create_blob(filename: "funky.jpg"), create_blob(filename: "town.jpg") ] | |||
| assert @user.highlights.attached? | |||
| assert_predicate @user.highlights, :attached? | |||
|
|
|||
| @user.reload | |||
| assert_not @user.highlights.attached? | |||
There was a problem hiding this comment.
I think we should extend the rubocop rule to also account for assert_not -> assert_not_predicate usages
rafaelfranca
deleted the
enable-minitest-assert-predicate-rubocop-rule
branch
koic
added a commit
to koic/rubocop-rails_config
that referenced
this pull request
Oct 15, 2023
Follow up rails/rails#49628. This PR enables `Minitest/AssertPredicate` cop.
koic
added a commit
to koic/rubocop-rails_config
that referenced
this pull request
Oct 15, 2023
Follow up rails/rails#49628. This PR enables `Minitest/AssertPredicate` cop.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit enables
Minitest/AssertPredicaterubocop rule and autocorrects violationsThis is one of the rules which has very little to debate about. Using
assert_predicatedoesn't hurt readability but its greatest benefit in the error message it produces when the assertion fails. While regularassertwill simply tell "expected false to be truthy" theassert_predicateproduces a very helpful error message like "expected <your_object_inspect> to be :valid?" i.e.Expected <Order#asb123 id: 1> to be :shipped?