-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set load_defaults to current Rails version in bug_report_templates #49631
Set load_defaults to current Rails version in bug_report_templates #49631
Conversation
I think this would simpler and would make the templates better reflect a real app. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another question is why not use
load_defaults
to the latest version in the bug_report_templates?I think this would simpler and would make the templates better reflect a real app.
Agreed. However, instead of specifying 7.1
, let's use config.load_defaults Rails::VERSION::STRING.to_f
, as we do when generating dummy apps. That way we don't have to update the version in the future, and the guides/bug_report_templates/*_main.rb
files will pick up the 7.2 defaults.
Currently only Action Mailbox and Active Storage use initialized apps, so at least in those cases we can ensure the correct defaults are used by bug reporters.
bea032e
to
f522f99
Compare
Let's use Still, I think part of my intention here was to reduce noise from the bug report templates which might lead contributors astray. |
Thank you, @zzak! 👍
I don't follow.
I ran both |
Sorry, I was confused. You're correct using Otherwise the default value is still set to 6.1: This comes up a bit, so it's easy to forget the two. (#49543, #49892) |
Currently only Action Mailbox and Active Storage use initialized apps, so at least in those cases we can ensure the correct defaults are used by bug reporters.