Fix failing linter in guides/source
#49660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix [Failing CI Lint][] Adds a missing comma to make an example Ruby block syntactically valid. [Failing CI Lint]: https://github.com/rails/rails/actions/runs/6539678344/job/17758241844?pr=49486#step:4:12
seanpdoyle
force-pushed
the
fix-guides-ci
branch
from
e1e7aa3
to
8ecbdb3
Compare
seanpdoyle
changed the title
guides/source [ci skip]guides/source
seanpdoyle
referenced
this pull request
Oct 16, 2023
We never explained how migrations paths work for shards. This fixes that and also adds the appropriate class setup. You no longer need to set a `default` shard as of #48353. In addition, `ApplicationRecord` should be used for the non-sharded db that also serves as the tenant/shard router. Then shards should get their own connection class since the schema differs.
skipkayhil
pushed a commit
that referenced
this pull request
Oct 17, 2023
Fix failing linter in `guides/source`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Background
Fix Failing CI Lint
Adds a missing comma to make an example Ruby block syntactically valid.