Fix extra blank line when no error_highlight #49666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A new condition was recently [added][1] to exclude error_highlight from the Gemfile when the Ruby version is 3.2 or greater. However, this change leads to an extra blank line after `gem "spring"` on Ruby 3.2+. This could also happen to new apps generated on Rubies < 3.1, but my guess is that is less common. This commit fixes the issue by moving the extra blank line into the condition. [1]: d7b3951
|
Thank you, @skipkayhil! ✂️ Backported to
|
jonathanhefner
added a commit
that referenced
this pull request
Oct 17, 2023
Fix extra blank line when no error_highlight (cherry picked from commit c139e52)
🤦 thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Background
A new condition was recently added to exclude error_highlight from the Gemfile when the Ruby version is 3.2 or greater. However, this change leads to an extra blank line after
gem "spring"on Ruby 3.2+. This could also happen to new apps generated on Rubies < 3.1, but my guess is that is less common.Detail
This commit fixes the issue by moving the extra blank line into the condition.
Additional Information
I think this should definitely be backported to 7.1,
and I can see an argument for 7.0 as well since a 7.0 app generated on ruby 2.7 or 3.0 would have the same issue.Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]