Fix decoding data encoded using a non-String purpose #49669
Conversation
Data encoded using a non-String purpose and `use_message_serializer_for_metadata == false` was incorrectly decoded, triggering a "mismatched purpose" error during decode. Fix this by ensuring that we compare both sides as a String.
intrip
force-pushed
the
fix-message-metadata-non-str
branch
from
788e669
to
cebdf71
Compare
| @@ -82,7 +82,7 @@ def extract_from_metadata_envelope(envelope, purpose: nil) | |||
| throw :invalid_message_content, "expired" | |||
| end | |||
|
|
|||
| if hash["pur"] != purpose&.to_s | |||
| if hash["pur"].to_s != purpose.to_s | |||
There was a problem hiding this comment.
Wouldn't hash["pur"].to_s result in matching purpose for "1" and 1?
There was a problem hiding this comment.
Correct, the new serialization already transforms the purpose in a String so hash["pur"] is always a String if serialized with the new logic.
The old serialization, on the other hand doesn't do it and this introduces a mismatch.
Isn't fine to always compare purpose as a String? We are already doing it after all.
There was a problem hiding this comment.
It seems like the old comparison implementation was also calling to_s:
https://github.com/rails/rails/blame/ebc3b660e51c5bdfd639639bb3c605d522d1a728/activesupport/lib/active_support/messages/metadata.rb#L67
So this looks good to me.
|
Should this be backported? |
Fix decoding data encoded using a non-String purpose
|
Backported as 02e3f69 |
Data encoded using a non-String purpose and
use_message_serializer_for_metadata == falsewas incorrectly decoded,triggering a "mismatched purpose" error during decode.
Fix this by ensuring that we compare both sides as a String.
Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]