Drop dependency on mutex_m

[casperisfine]

It used to be stdlib but is being extracted in modern rubies.

Overall its usefulness is dubious. In all cases it is included in Rails, it's only for the synchronize method, but end up exposing a dozen other useless methods.

In the end just using a Mutex is clearer and simpler.

In some cases we can even get away with a single mutex in a constant.

[tisba]

hmm, this hasn't made it into 7.1.2, right? Quite the contrary it is a direct dependency of ActiveSupport: https://github.com/rails/rails/blob/v7.1.2/activesupport/activesupport.gemspec

🤔

[byroot]

We don't backport this kind of patches.

[tisba]

Alright 👍

PS: I only noticed this because our builds on GH Actions started to break since mutex_m was added as an dependency 😞

/opt/hostedtoolcache/Ruby/3.2.2/x64/lib/ruby/gems/3.2.0/gems/bundler-2.4.22/lib/bundler/runtime.rb:304:in `check_for_activated_spec!': You have already activated mutex_m 0.1.2, but your Gemfile requires mutex_m 0.2.0. Since mutex_m is a default gem, you can either remove your dependency on it or try updating to a newer version of bundler that supports mutex_m as a default gem. (Gem::LoadError)

Still investigating, but will file an issue unless that's clearly something on our end.

[byroot]

Sounds like a bundler bug.

[byroot]

Actually, bundler doesn't use mutex_m, so must be something else requiring it early. I recommend editing mutex_m 0.1.2 to put a puts caller in it to track who is loading it.

[tisba]

Actually, bundler doesn't use mutex_m, so must be something else requiring it early. I recommend editing mutex_m 0.1.2 to put a puts caller in it to track who is loading it.

Yeah, that was plan too. Going to test this out shortly. It fails right away with bundle exec rails db:prepare (after a ruby/setup-ruby@v1 step).

[tisba]

I did not edit the mutex_m gem as I had a hunch that the only thing running before rails/my code is spring. And it looks like this is issue: https://github.com/rails/spring/blob/v4.1.1/lib/spring/watcher/abstract.rb#L2. Turns out that the last commit to main is in fact to add mutex_m as an explicit dependency 😄 rails/spring@6b2001f

I'll open an issue over there asking for a release.

[byroot]

I'll take care of it, thanks for finding it.

[byroot]

Ref: rails/spring#703

[byroot]

Spring 4.1.2 is out.