[ci skip] Update Action Mailer guide on how to add images #49712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatheusRich
force-pushed
the
mr/docs-for-action-mailer-asset-host
branch
2 times, most recently
from
4b7dbea
to
908c0ba
Compare
There was a problem hiding this comment.
In this document, it mentioned not to add include the protocol in those asset host config, If it not correct, can we remove that one also?
|
@akhilgkrishnan I think that's correct in that case because controllers can infer the protocol from the request. |
| ``` | ||
|
|
||
| NOTE: Because we can't infer the protocol from the request, you'll need to | ||
| specify a protocol or "scheme" such as `http://` or `https://.` in the |
There was a problem hiding this comment.
Suggested change
| specify a protocol or "scheme" such as `http://` or `https://.` in the | |
| specify a protocol such as `http://` or `https://.` in the |
Nit -- let's be concise and just call it a protocol?
There was a problem hiding this comment.
I'm good with that. I was just mirroring other parts of the documentation.
MatheusRich
commented
Oct 24, 2023
There was a problem hiding this comment.
@MatheusRich can you squash your commits please? Thank you!
Unlike controllers, mailers can't infer the protocol from the request, so users need to specify it.
MatheusRich
force-pushed
the
mr/docs-for-action-mailer-asset-host
branch
from
599d98b
to
f18e3d3
Compare
|
@adrianna-chang-shopify done! |
adrianna-chang-shopify
added a commit
that referenced
this pull request
Oct 25, 2023
…asset-host [ci skip] Update Action Mailer guide on how to add images
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Background
Fixes #49656
Unlike controllers, mailers can't infer the protocol from the request, so users need to specify it.