Fix issue where bootstrap.rb
overwrites the level
of a BroadcastLogger
's broadcasts
#49721
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Background
This Pull Request has been created because in
bootstrap.rb
we set theRails.logger.level
toconfig.log_level
. But at this point, we may have already set up aBroadcastLogger
with multiple broadcasts that have different levels. So, callinglevel=
on theBroadcastLogger
will overwrite the level of the individual broadcasts. So instead, let's only set theRails.logger.level
if the logger is not aBroadcastLogger
.Detail
We already have an
unless Rails.logger.is_a?(ActiveSupport::BroadcastLogger)
block on the next line of the code, so I just move the call toRails.logger.level =
within there.Additional information
Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]