fix singularization of "fives" was fife, but needs to be five #4974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ex: "A pair of fives" vs. "They played fifes"
|
Please fix it in your app inflections. We are not adding new inflections to Rails. |
|
Already fixed there. Just thought I'd share. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ex: "A pair of fives" vs. "They played fifes"
Also, combined hive, five, and tive in the singularizations. I tried running the tests, but I wasn't able to get them running quick enough. Swamped at work so I might have time later to run the tests, but if someone else wants to contribute to this minor effort, feel free.