Clarify ActiveModel::SecurePassword maximum password length [ci skip] #49758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since 74264f4 improved the secure_password length validation to match bcrypt limit, this validation can be described more accurately in the ActiveModel basics guide.
adrianna-chang-shopify
approved these changes
Oct 24, 2023
adrianna-chang-shopify
added a commit
that referenced
this pull request
Oct 24, 2023
Clarify ActiveModel::SecurePassword maximum password length [ci skip]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Background
While 74264f4 improved the secure_password length validation to match bcrypt limit of 72 bytes, the ActiveModel basics guide only documents an unit-less
72as the maximum length allowed.Detail
This Pull Request modifies the ActiveModel basics guide to more accurately describe secure_password length validation.
Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]