Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ActionMailer Email Preview - show date header when present #49790

Merged
merged 1 commit into from
Nov 4, 2023

Conversation

sampatbadhe
Copy link
Contributor

Detail

ActionMailer Email Preview - show date header when present or fallback to Time.current.rfc2822

Resolves #49788

Co-authored-by: @allisonphillips

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one change. Changes that are unrelated should be opened in separate PRs.
  • Commit message has a detailed description of what changed and why. If this PR fixes a related issue include it in the commit message. Ex: [Fix #issue-number]
  • Tests are added or updated if you fix a bug or add a feature.
  • CHANGELOG files are updated for the changed libraries if there is a behavior change or additional feature. Minor bug fixes and documentation changes should not be included.

@rails-bot rails-bot bot added the railties label Oct 26, 2023
@Edouard-chin
Copy link
Member

Should be quick and easy to add a test, mind adding one similar to this one ?

test "mailer preview sender tags" do

@sampatbadhe
Copy link
Contributor Author

Thank you for review @Edouard-chin. I have added tests, could you please check.

Copy link
Member

@Edouard-chin Edouard-chin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A minor suggestion, but it looks great otherwise. Thanks!

railties/test/application/mailer_previews_test.rb Outdated Show resolved Hide resolved
@jonathanhefner jonathanhefner merged commit 354e435 into rails:main Nov 4, 2023
4 checks passed
@jonathanhefner
Copy link
Member

I felt like this was worth a CHANGELOG entry, so I pushed a commit to add one.

Thank you, @sampatbadhe! 📫 And thank you, @Edouard-chin! 👋

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[includes solution] ActionMailer Email Preview ignoring optional date header
3 participants