Fix deprecation warnings for secrets:edit/show
#49792
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Background
This Pull Request has been created because there is a bug in the deprecation notices on the tasks
secrets:edit
andsecrets:show
which means they can raiseundefined method 'squish'
Reproduction
Create a new rails 7.1.1 app using
rails new
.cd
into the new app and runbin/rails secrets:edit
orbin/rails secrets:show
.For example:
Detail
The warning string is
#squish
ed howeveractive_support/core_ext/string/filters
is not being required.The tests are passing because the dummy test application does a
require 'rails/all'
on boot which requires the String extensions. https://github.com/rails/rails/blob/main/railties/test/isolation/abstract_unit.rb#L605This is not necessarily the case for other applications, eg ones freshly created with
rails new
so in this case an error is raised.The fix is to just require the necessary String extensions.
I am not sure if there is anything that could be done to the tests to have caught this.
Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]