Move new warning after example of previous warning [ci-skip] #49884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p8
changed the title
4 tasks
|
Thanks Petrik ❤️ |
zzak
reviewed
Nov 3, 2023
| @@ -585,6 +573,18 @@ irb> @user.save # updating @user | |||
| User was saved to database | |||
| ``` | |||
|
|
|||
| WARNING. In the context of a single transaction, if you interact with multiple | |||
There was a problem hiding this comment.
This is maybe for another PR, but I find these huge walls of text (especially in a note/warning block) with no sample code to be difficult to catch.
p8
added a commit
to p8/rails
that referenced
this pull request
Nov 4, 2023
Move new warning after example of previous wanring [ci-skip]
p8
added a commit
that referenced
this pull request
Nov 4, 2023
…49912) Move new warning after example of previous wanring [ci-skip]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We probably also want to add headings for these warnings, to clarify where sections begin/end.
Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]