Clarify transaction callbacks section [ci-skip] #49885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rename "Dealing With Consistency" heading to "`after_commit` and `after_rollback`. To be more inline with other headings. The "Context Matters" heading has been renamed to "Aliases for `after_commit`", as this section is about aliases and `Context Matters` is a bit ambiguous. The warnings for `after_commit` and `after_rollback` better fit with the section about these callback methods.
p8
force-pushed
the
guides/transaction-callbacks
branch
from
ed1fc26
to
5b6f422
Compare
adrianna-chang-shopify
approved these changes
Nov 1, 2023
|
Thanks @adrianna-chang-shopify 🙂 |
|
I guess I was being a bit clever when coming up with those headings, but this is an improvement. Thanks! |
p8
added a commit
to p8/rails
that referenced
this pull request
Nov 4, 2023
Clarify transaction callbacks section [ci-skip]
p8
added a commit
that referenced
this pull request
Nov 4, 2023
Clarify transaction callbacks section [ci-skip]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename "Dealing With Consistency" heading to "
after_commitandafter_rollback, to be more inline with other headings.The
Context Mattersheading has been renamed toAliases for after_commit, as this section is about aliases andContext Mattersis a bit ambiguous.The warnings for
after_commitandafter_rollbackbetter fit with the section about these callback methods.Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]