Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expand the transaction callback ordering in guides [ci-skip] #49888

Merged
merged 1 commit into from Nov 2, 2023
Merged

Expand the transaction callback ordering in guides [ci-skip] #49888

merged 1 commit into from Nov 2, 2023

Conversation

p8
Copy link
Member

@p8 p8 commented Nov 1, 2023 •
edited

The ordering can now be configured.

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one change. Changes that are unrelated should be opened in separate PRs.
  • Commit message has a detailed description of what changed and why. If this PR fixes a related issue include it in the commit message. Ex: [Fix #issue-number]
  • Tests are added or updated if you fix a bug or add a feature.
  • CHANGELOG files are updated for the changed libraries if there is a behavior change or additional feature. Minor bug fixes and documentation changes should not be included.

@rails-bot rails-bot bot added the docs label Nov 1, 2023
@p8 p8 force-pushed the guides/ar-callbacks-ordering branch from df23530 to bbe04d3 Compare November 1, 2023 20:14
akhilgkrishnan
akhilgkrishnan reviewed Nov 2, 2023
View reviewed changes
Copy link
Member

@akhilgkrishnan akhilgkrishnan left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a minor suggestion.

guides/source/active_record_callbacks.md Outdated Show resolved Hide resolved
akhilgkrishnan
akhilgkrishnan approved these changes Nov 2, 2023
View reviewed changes
Copy link
Member

@akhilgkrishnan akhilgkrishnan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @p8 for the changes 👍

@p8 p8 force-pushed the guides/ar-callbacks-ordering branch from c2ac835 to 9e0c3cb Compare November 2, 2023 09:14
@p8
Copy link
Member Author

p8 commented Nov 2, 2023

I've also updated the Configuring guide and API docs.
In the Configuring guide "When true" seems more common than "When false", so I've used that instead.

@p8 @akhilgkrishnan
Expand the transaction callback ordering in guides [ci-skip]
14acab2 
The ordering can now be configured.

Also update the Configuring guide and API docs. In the Configuring guide
"When true" seems more common than "When false", so that is used
instead.

Co-authored-by: Akhil G Krishnan <akhilgkrishnan4u@gmail.com>
@p8 p8 force-pushed the guides/ar-callbacks-ordering branch from 9e0c3cb to 14acab2 Compare November 2, 2023 09:17
@p8 p8 merged commit bbc6230 into rails:main Nov 2, 2023
3 checks passed
@p8 p8 deleted the guides/ar-callbacks-ordering branch November 2, 2023 09:26
@p8
Copy link
Member Author

p8 commented Nov 2, 2023

Thanks @akhilgkrishnan !

p8 added a commit to p8/rails that referenced this pull request Nov 4, 2023
@p8
Merge pull request rails#49888 from p8/guides/ar-callbacks-ordering
760a4c0 
Expand the transaction callback ordering in guides [ci-skip]
p8 added a commit that referenced this pull request Nov 4, 2023
@p8
Merge pull request #49888 from p8/guides/ar-callbacks-ordering (#49914)
909214d 
Expand the transaction callback ordering in guides [ci-skip]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akhilgkrishnan akhilgkrishnan akhilgkrishnan approved these changes

Assignees
No one assigned
Labels
activerecord docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@p8 @akhilgkrishnan