Do not use INSERT IGNORE
when upserting to MariaDB
#49890
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #49840.
In that PR, the logic for inserting with skipping duplicates was rewritten to use
INSERT IGNORE
.As it turned out in #49840 (comment), this change generates a warning inside the database. So in this PR, I reverted that change. Also added a test case to avoid such change in the future.
cc @jhawthorn