Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move the association callbacks section to the callbacks guides [ci-skip] #49907

Merged
merged 1 commit into from Nov 4, 2023
Merged

Move the association callbacks section to the callbacks guides [ci-skip] #49907

merged 1 commit into from Nov 4, 2023

Conversation

p8
Copy link
Member

@p8 p8 commented Nov 3, 2023 •
edited

Association callbacks were missing in the callbacks guide.
We can still keep a small section in the associations guide that links to the callbacks guide.

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one change. Changes that are unrelated should be opened in separate PRs.
  • Commit message has a detailed description of what changed and why. If this PR fixes a related issue include it in the commit message. Ex: [Fix #issue-number]
  • Tests are added or updated if you fix a bug or add a feature.
  • CHANGELOG files are updated for the changed libraries if there is a behavior change or additional feature. Minor bug fixes and documentation changes should not be included.

@rails-bot rails-bot bot added the docs label Nov 3, 2023
@p8 p8 changed the title Move the association callbacks guides to the callbacks guides. [ci-skip] Move the association callbacks section to the callbacks guides [ci-skip] Nov 3, 2023
@p8 p8 force-pushed the guides/association-callbacks branch from 46705df to b693fd6 Compare November 3, 2023 21:04
@p8
Move the association callbacks section to the callbacks guides [ci-skip]
a904df9 
Association callbacks were missing in the callbacks guide.
We can still keep a small section in the associations guide that links
to the callbacks guide.
@p8 p8 force-pushed the guides/association-callbacks branch from b693fd6 to a904df9 Compare November 3, 2023 21:29
@p8 p8 merged commit c079b5f into rails:main Nov 4, 2023
3 checks passed
@p8 p8 deleted the guides/association-callbacks branch November 4, 2023 08:25
@p8
Copy link
Member Author

p8 commented Nov 4, 2023

Thanks @zzak and @akhilgkrishnan !

p8 added a commit to p8/rails that referenced this pull request Nov 4, 2023
@p8
Merge pull request rails#49907 from p8/guides/association-callbacks
d99b482 
Move the association callbacks section to the callbacks guides [ci-skip]
p8 added a commit that referenced this pull request Nov 4, 2023
@p8
Merge pull request #49907 from p8/guides/association-callbacks (#49915)
9131f2d 
Move the association callbacks section to the callbacks guides [ci-skip]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zzak zzak zzak approved these changes

@akhilgkrishnan akhilgkrishnan akhilgkrishnan approved these changes

Assignees
No one assigned
Labels
docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@p8 @zzak @akhilgkrishnan