Add JavascriptPackageTest for Action Text
#49932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This mirrors the existing `JavascriptPackageTest` tests for UJS, Action Cable, and Active Storage.
jonathanhefner
added a commit
that referenced
this pull request
Nov 6, 2023
…package_test Add `JavascriptPackageTest` for Action Text (cherry picked from commit 3764d7b)
jonathanhefner
added a commit
that referenced
this pull request
Nov 6, 2023
…package_test Add `JavascriptPackageTest` for Action Text (cherry picked from commit 3764d7b)
jonathanhefner
added a commit
that referenced
this pull request
Nov 9, 2023
…ascript_package_test" It's not clear why, but the output of `yarn build` for `actiontext/rollup.config.js` and `app/javascript/actiontext/index.js` has changed since those files were last commited. Specifically, the built `app/assets/javascripts/actiontext.js` now defines top-level functions whereas it previously defined an IIFE even with `format: "es"`. (See also 8a34a93 which addresses this issue for `7-1-stable` by adding a separate UMD build.) Therefore, this commit reverts 91d4731 to use the last known acceptable version of `app/assets/javascripts/actiontext.js`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This mirrors the existing
JavascriptPackageTesttests for UJS, Action Cable, and Active Storage.