Update documentation in asset_tag_helper.rb [ci-skip] #49957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
These seem like nice improvements. 👍 However, usage of + in RDoc is limited to name-like strings. For example you can write +foobar+, but not +foo bar+. Instead, you must write <tt>foo bar</tt>.
I believe all strings you've marked up here must use <tt> due to including either whitespace or other punctuation marks.
jonathanhefner
changed the title
|
Ah! I had originally gone through and added backticks to them, then simply copied the |
Just a wee bit of visualization changes to make it more explicitly clear what is being passed (a quoted number) Co-authored-by: Jonathan Hefner <jonathan@hefner.pro>
jonathanhefner
force-pushed
the
patch-1
branch
from
cc662d1
to
94de154
Compare
|
I pushed a commit to squash the commits. Thank you, @gjtorikian! 📜 |
jonathanhefner
added a commit
that referenced
this pull request
Nov 7, 2023
Update documentation in asset_tag_helper.rb [ci-skip] (cherry picked from commit 253cddd)
jonathanhefner
added a commit
that referenced
this pull request
Nov 7, 2023
Update documentation in asset_tag_helper.rb [ci-skip] (cherry picked from commit 253cddd)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a wee bit of visualization changes to make it more explicitly clear what is being passed (a quoted number).
I found the lack of visualization on the docs site a bit hard to understand.