Pass along with_raw_connection params in PG adapter #49970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit we were passing `allow_retry` and `materialize_transactions` through from `execute_and_clear` to `exec_cache`/`exec_no_cache`, but then doing nothing with them. We've got a few internal queries using `execute_and_clear` (mostly via `internal_exec_query`) that are passing `allow_retry: true` and `materialize_transactions: false`. These calls will fail on connection errors that might have been retryable. It's also possible they are materializing transactions earlier than expected (although probably not—most of the methods look like they would be called only by us, always outside a transaction). This commit forwards the arguments through to `with_raw_connection` so the callers get the behavior they likely expect.
|
I didn't add a test because this is more of an optimization than a bug fix, but I could probably test that one of the internal postgres queries retries after a disconnect if we'd like coverage. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit we were passing
allow_retryandmaterialize_transactionsthrough fromexecute_and_cleartoexec_cache/exec_no_cache, but then doing nothing with them.We've got a few internal queries using
execute_and_clear(mostly viainternal_exec_query) that are passingallow_retry: trueandmaterialize_transactions: false. These calls will fail on connection errors that might have been retryable. It's also possible they are materializing transactions earlier than expected (although probably not—most of the methods look like they would be called only by us, always outside a transaction).This commit forwards the arguments through to
with_raw_connectionso the callers get the behavior they likely expect.Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]