Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove duplicate test whose name doesn't match the tested method #49975

Merged
merged 1 commit into from
Nov 8, 2023

Conversation

cjilbert504
Copy link
Contributor

Motivation / Background

This Pull Request has been created because in working on another PR I encountered a duplicate test. As you can see in the screenshot below the two tests are the same and the title for the duplicate test doesn't match the method that is actually being tested:
CleanShot 2023-11-08 at 15 49 10

Detail

This Pull Request removes the duplicate test.

Additional information

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one change. Changes that are unrelated should be opened in separate PRs.
  • Commit message has a detailed description of what changed and why. If this PR fixes a related issue include it in the commit message. Ex: [Fix #issue-number]
  • Tests are added or updated if you fix a bug or add a feature.
  • CHANGELOG files are updated for the changed libraries if there is a behavior change or additional feature. Minor bug fixes and documentation changes should not be included.

@rails-bot rails-bot bot added the actionview label Nov 8, 2023
@cjilbert504 cjilbert504 changed the title remove duplicate test whos name doesn't match the tested method remove duplicate test whose name doesn't match the tested method Nov 8, 2023
Copy link
Member

@jonathanhefner jonathanhefner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this test was added way back in 67f81cc#diff-5dc345f4739a220189802671408a670f46f32566d1d685aa12849156735dfeb6R275 and is indeed the result of a copy + paste error. Also, form_with has no equivalent error conditions.

@jonathanhefner jonathanhefner merged commit 60d05cd into rails:main Nov 8, 2023
4 checks passed
@jonathanhefner
Copy link
Member

Thank you, @cjilbert504! ✂️

@cjilbert504
Copy link
Contributor Author

@jonathanhefner - you bet, thank you as well!

@cjilbert504 cjilbert504 deleted the duplicate-form-for-test branch November 8, 2023 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants