Fix using self.inherited removing filter_attributes & GeneratedAssociationMethods generated multiple times
#50012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes issue rails#50003 where using `super` after adding relations to the subclass or defining filter attributes in the subclass in the method `self.inherited` lead to warnings and removed previously defined filter_attributes
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issue #50003 where using
superafter adding relations to the subclass or defining filter attributes in the subclass in the methodself.inheritedlead to warnings and removed previously defined filter_attributes.Motivation / Background
Fixes #50003.
Detail
I only added the
||=to@filter_attributesand@generated_association_methods, the other 3 variables in this code should not be affected. That way, only two additionalORoperations are introduced.Additional information
I added some tests as well, if the tests are run in an environment with strict warnings enabled it also verifies that the constant mentioned in #50003 is not redefined.
Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]