DatabaseConfigurations#configs_for can accept a symbol in the name param #50061
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Background
This Pull Request has been created because I am changing usages of
find_db_config
toconfigs_for
in my app. I noticed that while you can pass a symbol tofind_db_config
you cannot forconfigs_for
, meaning I have to add.to_s
at call sites where I might be passing a symbol in. I think it would be nice ifconfigs_for
'sname
parameter worked with a symbol or a string.Detail
This Pull Request changes the
ActiveRecord::DatabaseConfigurations#configs_for
method to accept a symbol for thename
parameter. Thename
parameter is used for comparison in one place, so I just callto_s
on it there.Additional information
Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]