Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use api.rubyonrails.org URLs in README.rdoc [ci-skip] #50062

Merged
merged 1 commit into from
Nov 14, 2023

Conversation

jonathanhefner
Copy link
Member

Follow-up to #49995.

Prior to this commit, link:classes/... URLs were used in README.rdoc files so that the URLs would be versioned when rendered at api.rubyonrails.org. However, outside of api.rubyonrails.org, such URLs aren't properly resolved.

Since rails/sdoc#345, https://api.rubyonrails.org/classes/... URLs will also be versioned when rendered at api.rubyonrails.org, and such URLs are properly resolved everywhere. Therefore, this commit converts link:classes/... URLs to that form.

Follow-up to rails#49995.

Prior to this commit, `link:classes/...` URLs were used in `README.rdoc`
files so that the URLs would be versioned when rendered at
api.rubyonrails.org.  However, outside of api.rubyonrails.org, such URLs
aren't properly resolved.

Since rails/sdoc#345, `https://api.rubyonrails.org/classes/...` URLs
will also be versioned when rendered at api.rubyonrails.org, and such
URLs are properly resolved everywhere.  Therefore, this commit converts
`link:classes/...` URLs to that form.
@jonathanhefner jonathanhefner merged commit 67bc765 into rails:main Nov 14, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant