Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change disjunction to conjunction in suggestion #50108

Merged
merged 1 commit into from
Nov 19, 2023

Conversation

jonathanhefner
Copy link
Member

Follow-up to #50104.

The error conditions are that the adapter is spelled incorrectly or the necessary gem isn't in the Gemfile. Therefore, to fix the error, the user must ensure that the adapter is spelled correctly and the gem is in the Gemfile.

This commit also adds require "active_support/core_ext/string/filters", which technically should be included for String#squish.

Follow-up to rails#50104.

The error conditions are that the adapter is spelled incorrectly __or__
the necessary gem isn't in the `Gemfile`.  Therefore, to fix the error,
the user must ensure that the adapter is spelled correctly __and__ the
gem is in the `Gemfile`.

This commit also adds `require "active_support/core_ext/string/filters"`,
which technically should be included for `String#squish`.
@jonathanhefner jonathanhefner merged commit c2a3305 into rails:main Nov 19, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant