Don't add default-mysql-client when running db:system:change to Trilogy
#50170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zzak
reviewed
Nov 26, 2023
|
|
||
| assert_file("Dockerfile") do |content| | ||
| assert_match "build-essential git", content | ||
| assert_match "curl libvips", content |
There was a problem hiding this comment.
Maybe we should add assert_no_match "default-libmysql-client", etc? Otherwise if someone accidentally adds back the dependency this test will still pass, right?
There was a problem hiding this comment.
Make sense to me. I added checking default-libmysqlclient-dev. Thanks!
There was a problem hiding this comment.
@y-yagi Why not add one for default-mysql-client too?
There was a problem hiding this comment.
@zzak
This is a test to prevent to addition of MySQL client packages when using Trilogy adapter. So I thought one package is enough.
y-yagi
force-pushed
the
fix-db_system_change-to-trilogy
branch
from
5d7ee69
to
4f966a5
Compare
…rilogy Trilogy doesn't depend on the libmariadb / libmysqlclient library Ref: https://github.blog/2022-08-25-introducing-trilogy-a-new-database-adapter-for-ruby-on-rails/#should-you-use-trilogy
y-yagi
force-pushed
the
fix-db_system_change-to-trilogy
branch
from
4f966a5
to
1e3e013
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Background
This Pull Request has been created because
db:system:change --to trilogyadds an unneeded package.Detail
This PR removed adding
default-mysql-clienttoDockerfilewhen runningdb:system:change --to trilogybecause Trilogy doesn't depend on the libmariadb / libmysqlclient library.Ref: https://github.blog/2022-08-25-introducing-trilogy-a-new-database-adapter-for-ruby-on-rails/#should-you-use-trilogy
Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]