Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve action view helpers guide [ci skip] #50199

Merged
merged 1 commit into from
Feb 9, 2024

Conversation

apoorv1316
Copy link
Contributor

Background

  • Fixed grammatical errors
  • Correct the typo in the path- app/assets/javascripts => app/assets/javascript

@rails-bot rails-bot bot added the docs label Nov 28, 2023
Copy link
Contributor

@adrianna-chang-shopify adrianna-chang-shopify left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think Rails can technically find any asset files under assets/*, but app/assets/javascripts is correct as the default lookup path: https://guides.rubyonrails.org/v7.0/asset_pipeline.html#search-paths

@skipkayhil skipkayhil force-pushed the improve-action-view-helper-guide branch from 3bf2c9c to a07fb7c Compare February 9, 2024 05:04
Co-authored-by: Apoorv Tiwari <tiwari.apoorv1316@gmail.com>
@skipkayhil skipkayhil force-pushed the improve-action-view-helper-guide branch from a07fb7c to 282d112 Compare February 9, 2024 05:07
@skipkayhil skipkayhil merged commit d127335 into rails:main Feb 9, 2024
3 checks passed
skipkayhil added a commit that referenced this pull request Feb 9, 2024
…guide

Improve action view helpers guide [ci skip]

Co-authored-by: Adrianna Chang <adrianna.chang@shopify.com>
skipkayhil added a commit that referenced this pull request Feb 9, 2024
…guide

Improve action view helpers guide [ci skip]

Co-authored-by: Adrianna Chang <adrianna.chang@shopify.com>
@skipkayhil
Copy link
Member

Thanks for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants