Lock irb to < 1.10 for now #50270
Merged
Lock irb to < 1.10 for now #50270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It breaks various `rails console` related integration tests: ``` Failure: FullStackConsoleTest#test_sandbox [test/application/console_test.rb:123]: "> " expected, but got: (END). Expected "\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n--More--\r \r(END)" to include "> ". ``` I tried to figure out a fix, but ran out of time, so in order to fix CI we can lock IRB for now.
|
It's also reported in #50267 and I'm working on a fix. I should be able to push a version to address it today. |
❤️ Let me know when you do, no rush, locking the version in the meantime is fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It breaks various
rails consolerelated integration tests:I tried to figure out a fix, but ran out of time, so in order to fix CI we can lock IRB for now.
I suspect it's no big deal, the way we simulate a TTY is probably confusing irb or reline
FYI: @zzak @st0012