Fix predicate builder for polymorphic models referencing models with composite primary keys #50319
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #50318.
I needed to create 2 models for the test case, because there is no currently Cpk model where both primary key columns are not
"id"
. When one of them is named"id"
, we do not get the error as in the linked issuerails/activerecord/lib/active_record/reflection.rb
Lines 875 to 879 in 5c4a7a7