Lock bigdecimal version to 3.1.4 or lower
#50331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit addresses the Rails CI using Ruby master branch failure because Rails CI enables `RAILS_STRICT_WARNINGS` to raise RuntimeError for warnings. https://buildkite.com/rails/rails/builds/102621#018c49df-e3de-4c2f-aeb7-6d8f08997da9/1102-1107 ```ruby /rails/activesupport/lib/active_support/core_ext/big_decimal/conversions.rb:4: warning: bigdecimal/util is found in bigdecimal, which will no longer be part of the default gems since Ruby 3.4.0. Add bigdecimal to your Gemfile or gemspec. (RuntimeError) ``` According to https://bugs.ruby-lang.org/issues/20058 , This failure has been triggered since ruby/ruby@cc98265 and it will be addressed once the bigdecimal 3.1.5 is available at rubygems.org . In the meantime, we can workaround this issue by logking `bigdecimal` version to 3.1.4 or lower. This commit should be reverted when the `bigdecimal` 3.1.5 is available at rubygems.org .
|
https://buildkite.com/rails/rails/builds/102706#018c5bef-ef7d-43c4-9031-0dc68d72a7c5
https://buildkite.com/rails/rails/builds/102706#018c5bef-ef88-40a8-8fd8-a1b10c9c07c5/1107-1131 |
|
Most of the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Background
This commit addresses the Rails CI using Ruby master branch failure because Rails CI enables
RAILS_STRICT_WARNINGSto raise RuntimeError for warnings.https://buildkite.com/rails/rails/builds/102621#018c49df-e3de-4c2f-aeb7-6d8f08997da9/1102-1107
Detail
According to https://bugs.ruby-lang.org/issues/20058 , This failure has been triggered since ruby/ruby@cc98265 and it will be addressed once the bigdecimal 3.1.5 is available at rubygems.org .
In the meantime, we can workaround this issue by logking
bigdecimalversion to 3.1.4 or lower. This commit should be reverted when thebigdecimal3.1.5 is available at rubygems.org .Additional information
Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]