Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document assert_queries and assert_no_queries [ci-skip] #50357

Merged

Conversation

siaw23
Copy link
Member

@siaw23 siaw23 commented Dec 14, 2023

Motivation / Background

This Pull Request has been created because #50281 is missing some documentation.

Detail

This Pull Request documents assert_queries and assert_no_queries

Additional information

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one change. Changes that are unrelated should be opened in separate PRs.
  • Commit message has a detailed description of what changed and why. If this PR fixes a related issue include it in the commit message. Ex: [Fix #issue-number]
  • Tests are added or updated if you fix a bug or add a feature.
  • CHANGELOG files are updated for the changed libraries if there is a behavior change or additional feature. Minor bug fixes and documentation changes should not be included.

@rails-bot rails-bot bot added the docs label Dec 14, 2023
@fatkodima
Copy link
Member

Maybe move these closer to the Active Record related assertions? The last ones are related to the controllers.

@fatkodima fatkodima merged commit fa32da9 into rails:main Dec 14, 2023
3 checks passed
@fatkodima
Copy link
Member

fatkodima commented Dec 14, 2023

Nevermind, the mentioned ones are not actually active record related.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants