Active Storage can be configured by STORAGE_URL #50477
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bparanj
reviewed
Dec 31, 2023
| @@ -32,5 +32,16 @@ def resolve(class_name) | |||
| rescue LoadError | |||
| raise "Missing service adapter for #{class_name.inspect}" | |||
| end | |||
|
|
|||
| def build_configurations(configurations) | |||
| if storage_url = ENV["STORAGE_URL"] | |||
There was a problem hiding this comment.
Is this supposed to be comparison or is it an assignment here?
There was a problem hiding this comment.
This is a conditional assignment, in order to give ENV["STORAGE_URL"] priority over the rest of the configuration.
Active Storage doesn't need to support multiple configurations if the URL is set, unlike AR where you can have 2 or 3-tierd configs, so this is a simpler approach.
| attr_reader :uri | ||
|
|
||
| def build_url_hash | ||
| service = uri.scheme && uri.scheme.tr("-", "_") |
There was a problem hiding this comment.
This can be refactored:
uri.scheme&.tr("-", "_")There was a problem hiding this comment.
This is just code I copied from AR:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #50448
NOTE: This is a proof-of-concept, that I came up with based on my understanding of ActiveRecord::DatabaseConfigurations and try to find a tiny seam to add support for this feature. Open to feedback and suggestions, but wanted to take a stab at this while it was fresh in my head.