Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require Rack 3 #50565

Open
rafaelfranca opened this issue Jan 3, 2024 · 3 comments
Open

Require Rack 3 #50565

rafaelfranca opened this issue Jan 3, 2024 · 3 comments
Milestone

Comments

@rafaelfranca
Copy link
Member

As this is a major version, let's drop support to Rack 2 and keep pushing the ecosystem forward.

@rafaelfranca rafaelfranca added this to the 8.0.0 milestone Jan 3, 2024
@ioquatix
Copy link
Contributor

ioquatix commented Jan 14, 2024

I am happy to do this, if you are happy with that. There is a lot of compatibility cruft that I am responsible for and I'd be glad to rip it all out.

In addition to this, I've been testing Rack head (what will be released as 3.1) with Rails head and found there were no issues (at least last time I checked). Rack head cleans up a lot of deprecations/Rack 2 compatibility stuff. It makes sense we stick with Rack 3.0+ but also start testing on both Rack 3.0 and Rack head (3.1).

@Earlopain
Copy link
Contributor

Some info to potentially consider: the unicorn webserver still doesn't work well with Rack 3, even though a patch for support has been available for almost a year now. https://yhbt.net/unicorn-public/ZHlX3HkxP6mK16If@jeremyevans.local/. This results in issues like #48195 because it doesn't prevent pulling in incompatible rack versions. It is questionable if a new release will even be made, and if that release will be available on RubyGems as per the maintainers comments in the mailing list.

People need to replace unicorn with something else in the future, waiting on unicorn will not push the ecosystem forward. Rails 8 is still months out anyways and things with unicorn have hopefully changed by then, though I would urge anyone that still uses unicorn to make plans to replace it regardless.

@rafaelfranca
Copy link
Member Author

https://github.com/Shopify/pitchfork if people are interested in moving on

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants