Handle all false args in config.x error check
#50569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow-up to rails#50050. Using `args.none?` does not catch the case when all args are `false` or `nil`. Therefore, this commit changes the condition to `args.empty?`. This commit also changes the error message to more closely match Ruby's error messages when trying to pass an arg to a getter method: ```ruby Rails.configuration.x(false) # => wrong number of arguments (given 1, expected 0) (ArgumentError) Rails.configuration.x.i_do_not_exist(false) # => wrong number of arguments (given 1, expected 0) when reading configuration `i_do_not_exist` (ArgumentError) ```
rafaelfranca
approved these changes
Jan 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #50050.
Using
args.none?does not catch the case when all args arefalseornil. Therefore, this commit changes the condition toargs.empty?.This commit also changes the error message to more closely match Ruby's error messages when trying to pass an arg to a getter method: