Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spell JavaScript correctly [ci-skip] #50611

Merged
merged 1 commit into from
Jan 6, 2024

Conversation

sato11
Copy link
Contributor

@sato11 sato11 commented Jan 6, 2024

Motivation / Background

Found an instance where "JavaScript" is spelled "Javascript."

Detail

Spelled it correctly. Also downcased the common noun, "dependencies."

Additional information

This is a follow-up to #50547.

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one change. Changes that are unrelated should be opened in separate PRs.
  • Commit message has a detailed description of what changed and why. If this PR fixes a related issue include it in the commit message. Ex: [Fix #issue-number]
  • Tests are added or updated if you fix a bug or add a feature.
  • CHANGELOG files are updated for the changed libraries if there is a behavior change or additional feature. Minor bug fixes and documentation changes should not be included.

@rails-bot rails-bot bot added the railties label Jan 6, 2024
Also downcase the common noun, "dependencies."

This is a follow-up to rails#50547.
@sato11 sato11 changed the title Spell JavaScript correctly Spell JavaScript correctly [ci-skip] Jan 6, 2024
@jonathanhefner jonathanhefner merged commit a25a66e into rails:main Jan 6, 2024
4 checks passed
@jonathanhefner
Copy link
Member

Thank you, @sato11! 🔠

By the way, for changes to template files it is better to omit "[ci-skip]", just in case there is some test checking the rendered result.

@sato11
Copy link
Contributor Author

sato11 commented Jan 6, 2024

@jonathanhefner Oh, I got it. Thank you too for the heads-up!

@sato11 sato11 deleted the spell-javascript-correctly branch January 6, 2024 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants