Fix view runtime for controllers with async queries #50634
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when there are async queries inside the controller, we get a negative view runtime reported. Something like
To reproduce, add something like this to the controller's action:
That is because when a query is executed in a separate thread, we increment the db runtime for the query
rails/activerecord/lib/active_record/runtime_registry.rb
Lines 27 to 29 in 7f34113
This way, we get a db execution time larger than the view rendering time (even though that queries are executed as part of the view rendering) and when we subtract them to get just the view rendering time here
rails/activerecord/lib/active_record/railties/controller_runtime.rb
Line 42 in 7f34113
In reality, we should subtract the time spent for queries inside the main thread, not the time spent executing the query inside the database.
cc @byroot (as implementor of async features)