Do not automatically require minitest-bisect (7-0-stable) #50659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is currently causing an issue in 6-1-stable CI due to a chain of dependencies: minitest-bisect -> minitest-server -> drb. The last working version of Drb for Ruby 2.5 and 2.6 includes usage of ruby2_keywords but does not declare a dependency on the shim gem (meaning that version of Drb actual does not work on those Ruby versions). ruby2_keywords was [added][1] to the 6-1-stable Active Support gemspec to address the issue with Drb, but this only fixes cases where Drb is required by Rails. However, there are still failing tests on 6-1-stable due to Drb being loaded in integration tests where a dummy Rails application calls Bundler.require and the above dependency chain is required. To address those test failures, this commit prevents minitest-bisect from being automatically required when the whole bundle is required. It is not strictly necessary for main or any stable branches other than 6-1-stable, but it seems more correct since minitest_bisect is ran as an external command anyways. [1]: 5a54e2f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #50656 to 7-0-stable