Module#delegate avoid creating a unique fstring for each delegator
#50698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafaelfranca
approved these changes
Jan 10, 2024
byroot
commented
Jan 10, 2024
For example: ```ruby delegate :negative?, to: :value, as: Numeric ``` Before: ``` def negative?(&block) _ = @value _.negative?(&block) rescue NoMethodError => e if _.nil? && e.name == :negative? raise DelegationError, "ActiveSupport::Duration#negative? delegated to @value.negative?, but @value is nil: #{self.inspect}" else raise end end ``` After: ```ruby def negative?(&block) _ = @value _.negative?(&block) rescue NoMethodError => e if _.nil? && e.name == :negative? raise DelegationError.nil_target(:negative?, :"@value") else raise end end ``` Before almost every delegator would generate a large unique string that gets interned for the error message that is rarely if ever used. Rather than to "hardcode" a unique string, we now only pass pre-existing symbols to a method helper that will build the error message. This alone saves about 160B per delegator, and the method bytecode is also marginally smaller (but it's harder to assess how much this actually saves)
byroot
force-pushed
the
delegate-reduce-fstring
branch
from
bfcde95
to
4bded3c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For example:
Before:
After:
Before almost every delegator would generate a large unique string that gets interned for the error message that is rarely if ever used.
Rather than to "hardcode" a unique string, we now only pass pre-existing symbols to a method helper that will build the error message.
This alone saves about 160B per delegator, and the method bytecode is also marginally smaller (but it's harder to assess how much this actually saves)