Prevent unnecessary application reloads in development #50708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the Rails application would reload due to changes in some files outside the autoload paths. For instance, editing `app/README.md` would trigger a reload, even though the reloaded classes and modules were identical to those loaded previously. This commit fixes this issue by ensuring the application reloads correctly according to `Rails.autoloaders.main.dirs`, thereby preventing unnecessary reloads. rails#37011 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Background
As commented in #37011 (comment),
previously, changes in some files outside the autoload paths triggered reloading application.
For instance, editing
app/README.mdwould trigger a reload,even though the reloaded classes and modules, which were under autoload paths,
were identical to those loaded previously.
Detail
This PR fixes this issue by ensuring the application reloads correctly
according to
Rails.autoloaders.main.dirs, thereby preventing unnecessary reloads.Additional information
I have fixed the issue according to the above comment.
Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]