Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the screenshot in the section 8.4 of Getting Started with Rails [ci skip] #50756

Merged
merged 1 commit into from
Jan 17, 2024

Conversation

Angy-h
Copy link

@Angy-h Angy-h commented Jan 15, 2024

Motivation / Background

I've been following the getting started guide. Upon reaching the end of section 8.4, I noticed several differences between the output displayed in the guide's screenshot and what appeared on my computer (rails version: Rails 7.1.2, ruby version: ruby 3.2.2):

  • The positioning of "Edit/Back" differs.
  • While the guide provides an explanation for "Destroy," it doesn't offer one for "Back."
  • My output lacked the "Title:" and "Text:" elements.
  • The text "Rails is Awesome!" appeared larger due to the h1 tag.

I would like to update the existing screenshot.

Detail

This Pull Request changes article_with_comments.png in /guides/assets/images/getting_started.

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one change. Changes that are unrelated should be opened in separate PRs.
  • Commit message has a detailed description of what changed and why. If this PR fixes a related issue include it in the commit message. Ex: [Fix #issue-number]
  • Tests are added or updated if you fix a bug or add a feature.
  • CHANGELOG files are updated for the changed libraries if there is a behavior change or additional feature. Minor bug fixes and documentation changes should not be included.

Replace the existing screenshot with the output produced in Rails 7. The current screenshot
seems to be captured in a previous version.
Copy link
Member

@akhilgkrishnan akhilgkrishnan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Angy-h for change 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants