Use includes instead of eager_load for with_all_rich_text
#50769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`eager_load` performs a single query using a `LEFT OUTER JOIN` to load the associations. Loading the associations in a join can result in many rows that contain redundant data and it performs poorly at scale. With `includes` a separate query is performed for each association, unless a join is required by conditions. Co-authored-by: Rafael Mendonça França <rafael@franca.dev>
p8
force-pushed
the
actiontext/eager-load-with-includes
branch
from
632f1b1
to
3b49e47
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Background
eager_loadperforms a single query using aLEFT OUTER JOINto load the associations. Loading the associations in a join can result in many rows that contain redundant data and it performs poorly at scale.With
includesa separate query is performed for each association, unless a join is required by conditions.includesis also used by similar methods in Active Storage likewith_attached_*.Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]