Fix t.references validating options on Rails < 7.1 #50773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Option validation was [added][1] for 7.1+ Migration classes, and a compatibility layer was added to ensure that previous Migration versions do not have their options validated. However, the `t.references` method was missing in the compatibility layer which results in pre 7.1 Migrations validating options passed to `t.references`. This commit fixes the issue by adding t.references to the compatibility layer. See also a [similar fix][2] for `add_reference` [1]: e6da3eb [2]: 71b4e22
rafaelfranca
added a commit
that referenced
this pull request
Jan 16, 2024
Fix t.references validating options on Rails < 7.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Background
Option validation was added for 7.1+ Migration classes, and a compatibility layer was added to ensure that previous Migration versions do not have their options validated. However, the
t.referencesmethod was missing in the compatibility layer which results in pre 7.1 Migrations validating options passed tot.references.Detail
This commit fixes the issue by adding t.references to the compatibility layer.
See also a similar fix for
add_referenceChecklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]