Fix threading issue with strict locals #50775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes rails#50774 When the server boots up, 2 threads hit the same `UnboundTemplate` instance before it has set up `@templates`. Both threads get past the `unless template = @templates[locals]` check because `@templates[locals]` isn't set yet. However, with `@write_lock`, one thread waits while the other one proceeds, setting `@templates` to a frozen hash. The second thread then gets the write lock and tries to modify `@templates` but it has been frozen.
|
Not sure why buildkite is failing. It's complaining about a missing config. |
rafaelfranca
added a commit
that referenced
this pull request
Jan 18, 2024
Fix threading issue with strict locals
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #50774
When the server boots up, 2 threads hit the same
UnboundTemplateinstance before it has set up
@templates. Both threads get past theunless template = @templates[locals]check because@templates[locals]isn't set yet. However, with@write_lock, onethread waits while the other one proceeds, setting
@templatesto afrozen hash. The second thread then gets the write lock and tries to
modify
@templatesbut it has been frozen.